Skip to content
This repository has been archived by the owner on Jun 29, 2024. It is now read-only.

Improve position and error system #71

Merged
merged 6 commits into from
Dec 3, 2023
Merged

Improve position and error system #71

merged 6 commits into from
Dec 3, 2023

Conversation

Gashmob
Copy link
Member

@Gashmob Gashmob commented Nov 29, 2023 •
edited
Loading

Closes #67
Closes #70

@Gashmob
feat: Add AbstractPosition
13d01ed 
Part of #67

All position class must heritate from AbstractPosition class
@Gashmob Gashmob added the enhancement New feature or request label Nov 29, 2023
@Gashmob Gashmob added this to the v0.3.0 milestone Nov 29, 2023
@Gashmob Gashmob self-assigned this Nov 29, 2023
This was linked to issues Nov 29, 2023
Improve Position system #67
Closed
Clean error system #70
Closed
@Gashmob
refactor: Position -> SimplePosition
e65c7c5 
Part of #67
@Gashmob
feat: Add DoublePosition
e787219 
Part of #67

DoublePosition is a position with a start and an end. It's needed when
you need to show position of a long expression
@Gashmob
fix: Issue from Codacy report
ee62db4
@Gashmob
feat: Reformat dump of position
2a86bc3 
Part of #67

New format is:

  --> <filename>:<line>:<column>
 1 | <content>
   |    ^

With some color:
 - '-->', '1 |' and '|' are colored in bold blue
@Gashmob
feat: Reformat print of messages
90018eb 
Part of #70
@codecov Codecov
Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Merging #71 (90018eb) into develop (245d6b0) will increase coverage by 2.13%.
The diff coverage is 90.51%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop      #71      +/-   ##
===========================================
+ Coverage    80.17%   82.30%   +2.13%     
===========================================
  Files           46       49       +3     
  Lines         1720     1820     +100     
===========================================
+ Hits          1379     1498     +119     
+ Misses         341      322      -19
Files Coverage Δ
src/lib/ast/AST.h 100.00% <ø> (ø)
src/lib/ast/AbstractExpression.cpp 100.00% <100.00%> (ø)
src/lib/ast/ArrayOperator.cpp 33.33% <ø> (ø)
src/lib/ast/AssignationOperator.cpp 52.94% <ø> (ø)
src/lib/ast/ClassicOperator.cpp 49.27% <ø> (ø)
src/lib/ast/FunctionOperator.cpp 30.76% <ø> (ø)
src/lib/ast/Identifier.cpp 82.75% <100.00%> (ø)
src/lib/message/DevWarning.cpp 90.90% <100.00%> (+90.90%) ⬆️
src/lib/message/Error.cpp 100.00% <100.00%> (+85.71%) ⬆️
src/lib/message/Error.h 100.00% <ø> (+100.00%) ⬆️
... and 5 more

... and 2 files with indirect coverage changes

@Gashmob Gashmob marked this pull request as ready for review December 2, 2023 11:13
@Gashmob Gashmob merged commit 94721d8 into develop Dec 3, 2023
13 checks passed
@Gashmob Gashmob deleted the dev-position branch December 3, 2023 10:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Gashmob Gashmob

Labels
enhancement New feature or request
Projects
No open projects
Fil
Archived in project
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

Clean error system Improve Position system
1 participant
@Gashmob